FuelPHP Forums

Mitchell

I'm hoping someone can verify if this is a bug or not. When using the Image class, I'm getting an error at core/classes/image/imagemagick.php @ line 18 ErrorException [ Runtime Notice ]: Declaration of Fuel\Core\Image_Imagemagick::load() should be compatible with that of Fuel\Core\Image_Driver::load() In /core/classes/image/driver.php shows the load function as:

public function load($filename, $return_data = false, $force_extension = false)

while in /core/classes/image/imagemagick.php the load function is:

public function load($filename, $return_data = false)

Seems like the extra parameter in driver.php is causing the error.

Harro

Looks like a bug. This commit introduced this feature, but it was only implemented for the gd driver. And we missed that when we merged the pull request. Thanks for reporting it. When you spot something like this, just create an issue at http://github.com/fuel/core/issues, not everyone follows the forums.

Harro

I've commited a fix (to develop), you can pick them from the 1.3/develop repo if needed.

Mitchell

Great. Thanks for your help. BTW, I posted this first in the forum instead of as a bug because I thought maybe I was doing something wrong (wouldn't be the first time).

Harro

No problem, I try to keep up with what's going on here. But you can reach the dev's quicker via an issue. We'll just tell you off and close it when you're wrong... lol.

Mitchell

Yeah, I've had that happen. ;>)

FuelPHP Forums

Ask your question about FuelPHP in the appropriate forum, or help others by answering their questions.

Howdy, Stranger!

Categories

In this Discussion