FuelPHP Forums

Can you explain what your issues where? I honestly don't see the difference:

// CodeIgniter example
 function do_upload()
 {
  $config['upload_path'] = './uploads/';
  $config['allowed_types'] = 'gif|jpg|png';
  $config['max_size'] = '100';
  $config['max_width']  = '1024';
  $config['max_height']  = '768';

  $this->load->library('upload', $config);

  if ( ! $this->upload->do_upload())
  {
   $error = array('error' => $this->upload->display_errors());

   $this->load->view('upload_form', $error);
  }
  else
  {
   $data = array('upload_data' => $this->upload->data());

   $this->load->view('upload_success', $data);
  }
 }

vs

// same in FuelPHP
 function do_upload()
 {
  // Custom configuration for this upload
  $config = array(
      'path' => DOCROOT.DS.'uploads/',
      'ext_whitelist' => array('img', 'jpg', 'jpeg', 'gif', 'png'),
  );

  // process the uploaded files in $_FILES
  Upload::process($config);

  // if there are any valid files
  if (Upload::is_valid())
  {
   // save them according to the config
   Upload::save();

   // call a model method to update the database
   Model_Uploads::add(Upload::get_files());
  }

  // and process any errors
  foreach (Upload::get_errors() as $file)
  {
   // $file is an array with all file information,
   // $file['errors'] contains an array of all error occurred
   // each array element is an an array containing 'error' and 'message'
  }
 }

In our upload class, per file processing is done via callbacks you can register. Sort of like hooks in the CI world, but then defined dynamically in your controller. We have choosen for this solution because there are a million and one ways you might want to treat the different files that have been uploaded. Hardcoded processing will never be able to handle all those. We also think that most of these processing rules (like for example the way CI uses the sizes) are very application and situation specific. And therefore don't belong in the framework. The framework should support the developer, not dicate how things should be done. The fact that this solution works for you, but not for me, is proof of that.

No problem. If someone has a decided not to use something provided by the framework that means we're doing something wrong. Either in code or in documentation. So I tend to ask about it, to understand the reasoning behind it. There a simple example in the docs, see http://docs.fuelphp.com/classes/upload/usage.html#/method_register There are three hooks available:
- validate, runs in process() after the standard validation is done, called for all uploaded files
- before, runs in save() before the file is saved to disk, called for validated files only
- after, runs in save() after the file has been saved to disk, called for validated files only Which one you use depends on what you want to do. For custom filenames and/or paths, you would use "before". The callback method is called for every file, and gets the file array passed (with the fields as documented). It's passed by reference, you can use the contents to determine your actions, and you can alter it's value (for example set a custom save path if it's a zip file larger then 2MB, or run an image resize if it's a jpeg and set a new source filename).

No problem, it's a way for us to see how we can improve the framework. This discussion has made me start to think about how to change the Upload class to make it easier to deal with multiple uploads which require different treatment. If you got five on your form you'll end up writing a lot of callback code for stuff the class can do itself...