FuelPHP Forums

Valid point, it doesn't take into account that you can have multiple errors. I'll see if I can fix this today ('messages' has to be an array of strings, instead of a string).

WanWizard, I just read your entry in the issues, and I think you may be referring to a different issue. Tell me if I'm wrong, but I believe your entry refers to the issue that if there is more than one upload error, e.g. file exceeded max size and file type not allowed, then the Upload class only saves the first error it encounters. This is true and would be nice to fix, however the issue I'm seeing is a bit more basic. For example, if I create 2 text fields and add the rule array('min_length', 3) to the first field and array('min_length', 5) to the 2nd text field, there's no problem or confusion with validation applying the appropriate rule to each field and generating a unique error message for each field. However, if I specify my own validation rule such as array(check_file_upload, $form_field) and apply it to more than 1 field, there is a problem. For example suppose for the first file field check_file_upload() calls set_message('check_file_upload', The uploaded file exceeds the defined maximum size'); And then for second file field check_file_upload() calls set_message('check_file_upload', 'The uploaded file exceeds the defined maximum size'); When the function show_errors() is called, the last error message reported is displayed for both fields. So for the example above, what gets displayed are 2 error messages that say "The uploaded file exceeds the defined maximum size."

Oh boy, now I'm confused. I created a validation function that uses the Upload class to check for file upload errors. Because there can be more than one file upload per page, the validation function is called for each upload file field. The idea is that if file #1 fails because it exceeds the max file size, then an error message can explain why it failed. If file #2 failed because the file type is not allowed, then a different error message is displayed for the 2nd file. Maybe a quick example would help:

 public function _validation_upload_ok($form_value, $form_field)
 {
  // Get files uploaded with errors
  $upload_errors = Upload::get_errors();

  // Check if this form field had an upload error
  foreach ($upload_errors as $error)
  {
   if ($error['field'] == $form_field)
   {
    $this->set_message('upload_ok', $error['message'] . ' (' . $error['name'] . ').');
    return false;
   }
  }
  return true;
 }

Yes, the last error message seems to overwrite the others. Actually, to be clear, the Upload::get_errors() function returns the correct error messages. I guess it's the show_errors() function that displays the wrong error message. The validation function is set up in the model set_form_fields() function using $form->add(). Here's a snippet of the code:

 public static function set_form_fields_example(Fieldset $form, $example_id = null)
 {
  if ($example_id != null)
  {
   $examples = self::get_example_info($example_id);
  }

  // File upload - set up several fields
  for ($i = 1; $i <= Model_Mexamples::N_FILES; $i++)
  &#123;
   $field = 'file_' . $i;
   $field_id = 'file-' . $i;

   $form->add($field,
    "Upload File $i",
    array(
     'type' => 'file',
     'size' => 50,
     'id' => $field_id,
    ),
    array(
     array('upload_ok', "$field"),
    )
   );
}

I think you may be right. Here's the Debug::dump() output from the first time through the validation function. I attempted to upload 2 files that generated 2 different error messages. You can see that Upload::get_errors() returns the correct error messages. APPPATH/classes/validation.php @ line: 344 Variable #1:
string(18) "Form field: file_1" Variable #2:
array(2) {
[0]=>
array(11) {
["name"]=>
string(18) "dbg_wizard_ide.txt"
["type"]=>
string(10) "text/plain"
["error"]=>
int(103)
["size"]=>
int(3576)
["field"]=>
string(6) "file_1"
["key"]=>
bool(false)
["file"]=>
string(24) "M:\xampp\tmp\php473E.tmp"
["extension"]=>
string(3) "txt"
["filename"]=>
string(14) "dbg_wizard_ide"
["mimetype"]=>
string(10) "text/plain"
["message"]=>
string(50) "Upload of files with this extension is not allowed"
}
[1]=>
array(10) {
["name"]=>
string(12) "Polar A3.pdf"
["type"]=>
string(17) ""application/pdf""
["error"]=>
int(101)
["size"]=>
int(230042)
["field"]=>
string(6) "file_2"
["key"]=>
bool(false)
["file"]=>
string(24) "M:\xampp\tmp\php473F.tmp"
["extension"]=>
string(3) "pdf"
["filename"]=>
string( "Polar A3"
["message"]=>
string(50) "The uploaded file exceeds the defined maximum size"
}
}

I suggest you add this as a feature request on http://github.com/fuel/core/issues, and ask Jelmer's opinion, he's the author of the validation class.